Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1638551 Only Emit Span Once in the Nested Actions #151

Merged
merged 1 commit into from
Aug 26, 2024
Merged

SNOW-1638551 Only Emit Span Once in the Nested Actions #151

merged 1 commit into from
Aug 26, 2024

Conversation

sfc-gh-bli
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Replace this with a short description of how your code change solves the related issue.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-bli
sfc-gh-bli commented Aug 26, 2024
View reviewed changes
src/main/scala/com/snowflake/snowpark/internal/OpenTelemetry.scala
try {
spanInfo.withValue[T](spanInfo.value match {
// empty info means this is the entry of the recursion
case None =>
Copy link
Collaborator Author

@sfc-gh-bli sfc-gh-bli Aug 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current design, the nest actions will emit same span multiple times. This fix skips the emit process in the nested action.

@sfc-gh-bli sfc-gh-bli merged commit 3ab8a52 into main Aug 26, 2024
16 checks passed
@sfc-gh-bli sfc-gh-bli deleted the snow-1638551 branch August 26, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-yuwang sfc-gh-yuwang sfc-gh-yuwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-bli @sfc-gh-yuwang